diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-07-26 09:44:45 -0400 |
|---|---|---|
| committer | Kevin O'Connor <kevin@koconnor.net> | 2018-07-26 09:44:45 -0400 |
| commit | 273a98d39a88a372c8a2c816622e7df1f777e77d (patch) | |
| tree | 2e8d4253f901a093d745127d97fd2464098d9266 /klippy/mcu.py | |
| parent | 7a9553b38a39398226d95b7569a0b889b8cdb10a (diff) | |
| download | kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.tar.gz kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.tar.xz kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.zip | |
pins: Explicitly pass can_invert and can_pullup to lookup_pin()
Don't pass pin_type to lookup_pin() - instead, if a pin can be
inverted or can have a pullup, then the caller must explicitly specify
that when calling lookup_pin(). This simplifies the code for the
cases where it is not valid to invert or pullup.
Explicitly pass the pin_type to setup_pin() and have ppins.setup_pin()
apply default pullup and invert flags.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'klippy/mcu.py')
| -rw-r--r-- | klippy/mcu.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/klippy/mcu.py b/klippy/mcu.py index a25fc3f7..3618e6a7 100644 --- a/klippy/mcu.py +++ b/klippy/mcu.py @@ -610,10 +610,9 @@ class MCU: self.register_msg(self._handle_mcu_stats, 'stats') self._check_config() # Config creation helpers - def setup_pin(self, pin_params): + def setup_pin(self, pin_type, pin_params): pcs = {'stepper': MCU_stepper, 'endstop': MCU_endstop, 'digital_out': MCU_digital_out, 'pwm': MCU_pwm, 'adc': MCU_adc} - pin_type = pin_params['type'] if pin_type not in pcs: raise pins.error("pin type %s not supported on mcu" % (pin_type,)) co = pcs[pin_type](self, pin_params) |