diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-07-26 09:44:45 -0400 |
|---|---|---|
| committer | Kevin O'Connor <kevin@koconnor.net> | 2018-07-26 09:44:45 -0400 |
| commit | 273a98d39a88a372c8a2c816622e7df1f777e77d (patch) | |
| tree | 2e8d4253f901a093d745127d97fd2464098d9266 /klippy/extras/buttons.py | |
| parent | 7a9553b38a39398226d95b7569a0b889b8cdb10a (diff) | |
| download | kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.tar.gz kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.tar.xz kutter-273a98d39a88a372c8a2c816622e7df1f777e77d.zip | |
pins: Explicitly pass can_invert and can_pullup to lookup_pin()
Don't pass pin_type to lookup_pin() - instead, if a pin can be
inverted or can have a pullup, then the caller must explicitly specify
that when calling lookup_pin(). This simplifies the code for the
cases where it is not valid to invert or pullup.
Explicitly pass the pin_type to setup_pin() and have ppins.setup_pin()
apply default pullup and invert flags.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'klippy/extras/buttons.py')
| -rw-r--r-- | klippy/extras/buttons.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/klippy/extras/buttons.py b/klippy/extras/buttons.py index 76727328..8c5c2bd0 100644 --- a/klippy/extras/buttons.py +++ b/klippy/extras/buttons.py @@ -141,7 +141,7 @@ class PrinterButtons: mcu = mcu_name = None pin_params_list = [] for pin in pins: - pin_params = ppins.lookup_pin('digital_in', pin) + pin_params = ppins.lookup_pin(pin, can_invert=True, can_pullup=True) if mcu is not None and pin_params['chip'] != mcu: raise ppins.error("button pins must be on same mcu") mcu = pin_params['chip'] |