From 273a98d39a88a372c8a2c816622e7df1f777e77d Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Thu, 26 Jul 2018 09:44:45 -0400 Subject: pins: Explicitly pass can_invert and can_pullup to lookup_pin() Don't pass pin_type to lookup_pin() - instead, if a pin can be inverted or can have a pullup, then the caller must explicitly specify that when calling lookup_pin(). This simplifies the code for the cases where it is not valid to invert or pullup. Explicitly pass the pin_type to setup_pin() and have ppins.setup_pin() apply default pullup and invert flags. Signed-off-by: Kevin O'Connor --- klippy/extras/buttons.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'klippy/extras/buttons.py') diff --git a/klippy/extras/buttons.py b/klippy/extras/buttons.py index 76727328..8c5c2bd0 100644 --- a/klippy/extras/buttons.py +++ b/klippy/extras/buttons.py @@ -141,7 +141,7 @@ class PrinterButtons: mcu = mcu_name = None pin_params_list = [] for pin in pins: - pin_params = ppins.lookup_pin('digital_in', pin) + pin_params = ppins.lookup_pin(pin, can_invert=True, can_pullup=True) if mcu is not None and pin_params['chip'] != mcu: raise ppins.error("button pins must be on same mcu") mcu = pin_params['chip'] -- cgit v1.2.3-70-g09d2