diff options
| author | Bevan Weiss <bevanweiss@users.noreply.github.com> | 2024-08-15 12:14:19 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-14 22:14:19 -0400 |
| commit | c0edfbc4ea02d7d0fb5824a686b4376a05972266 (patch) | |
| tree | 8c287118e2e50ddba5c910c4d704932a095fcdcc /src/sensor_ads1220.c | |
| parent | 3f2ef88eb9f8a24ba870933108b570da616428e2 (diff) | |
| download | kutter-c0edfbc4ea02d7d0fb5824a686b4376a05972266.tar.gz kutter-c0edfbc4ea02d7d0fb5824a686b4376a05972266.tar.xz kutter-c0edfbc4ea02d7d0fb5824a686b4376a05972266.zip | |
src: Current code produces warnings for possible value overflows. (#6665)
As the input values are uint8_t types, any shift may result in value loss.
Explicit promotion to the output type (uint32_t) keeps things safe.
Have also changed the int32_t in ads1220_read_adc to uint32_t, type
promotion and bit manipulation are a bit 'weird' on signed integers, so
keep it as an unsigned to align with following function call parameter type.
Have retained the prior explicit sign extension logic however.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Diffstat (limited to 'src/sensor_ads1220.c')
| -rw-r--r-- | src/sensor_ads1220.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/sensor_ads1220.c b/src/sensor_ads1220.c index 044980c7..ea33379a 100644 --- a/src/sensor_ads1220.c +++ b/src/sensor_ads1220.c @@ -86,7 +86,9 @@ ads1220_read_adc(struct ads1220_adc *ads1220, uint8_t oid) barrier(); // create 24 bit int from bytes - int32_t counts = (msg[0] << 16) | (msg[1] << 8) | msg[2]; + uint32_t counts = ((uint32_t)msg[0] << 16) + | ((uint32_t)msg[1] << 8) + | ((uint32_t)msg[2]); // extend 2's complement 24 bits to 32bits if (counts & 0x800000) |