diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-05-24 12:49:23 -0400 |
|---|---|---|
| committer | Kevin O'Connor <kevin@koconnor.net> | 2018-05-28 10:43:39 -0400 |
| commit | cb4e165071ad56c4cf881f5221f02eeefde5de53 (patch) | |
| tree | 0d88bd5e3ebaf53526cda428eebf3d7ad61876bf /src/pru/internal.h | |
| parent | 2a55741ea883e6a9958a64c3463b4c3d60c21b63 (diff) | |
| download | kutter-cb4e165071ad56c4cf881f5221f02eeefde5de53.tar.gz kutter-cb4e165071ad56c4cf881f5221f02eeefde5de53.tar.xz kutter-cb4e165071ad56c4cf881f5221f02eeefde5de53.zip | |
command: Prefer uint8_t* for buffers; prefer uint8_fast_t for lengths
Prefer using 'uint8_t' buffers as it is too easy to run into C sign
extension problems with 'char' buffers. Prefer using 'uint_fast8_t'
for buffer lengths as gcc does a better job compiling them on 32bit
mcus.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'src/pru/internal.h')
| -rw-r--r-- | src/pru/internal.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/pru/internal.h b/src/pru/internal.h index abbc9e40..dc125cd3 100644 --- a/src/pru/internal.h +++ b/src/pru/internal.h @@ -25,7 +25,7 @@ // Layout of shared memory struct shared_response_buffer { uint32_t count; - char data[MESSAGE_MAX]; + uint8_t data[MESSAGE_MAX]; }; struct shared_mem { uint32_t signal; @@ -36,7 +36,7 @@ struct shared_mem { const struct command_parser *command_index; uint32_t command_index_size; const struct command_parser *shutdown_handler; - char read_data[512]; + uint8_t read_data[512]; }; #define SIGNAL_PRU0_WAITING 0xefefefef |