diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-12-27 19:11:46 -0500 |
|---|---|---|
| committer | KevinOConnor <kevin@koconnor.net> | 2019-01-07 20:00:44 -0500 |
| commit | e26d1a356708b3702c91a86ff37f3c5c615941c9 (patch) | |
| tree | 89cbc00e3af6fe731c863da4a30b487b56a8badd /src/lpc176x/i2c.c | |
| parent | f2f54290e84903679bdb9548924f933a6efe311d (diff) | |
| download | kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.tar.gz kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.tar.xz kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.zip | |
i2ccmds: Pass the i2c address as a 7-bit number (0-127)
The sam3 i2c code and the linux code use a 7-bit i2c address, while
the avr, lpc176x, and samd21 i2c code uses an 8-bit address with the
least significant bit always zero. A similar issue occurred in the
host code (sx1509.py and replicape.py use 7-bit addresses while
uc1701.py and mcp4451.py use 8-bit addresses).
Consistently use 7-bit addresses in all the code. This breaks
compatibility between host and mcu software, so make a change to the
config_i2c command to force users to synchronize software updates.
This also breaks common Smoothieboard configs, so update the mcp4451
code to validate the i2c_address.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'src/lpc176x/i2c.c')
| -rw-r--r-- | src/lpc176x/i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lpc176x/i2c.c b/src/lpc176x/i2c.c index bc367ba7..420bef95 100644 --- a/src/lpc176x/i2c.c +++ b/src/lpc176x/i2c.c @@ -45,7 +45,7 @@ i2c_setup(uint32_t bus, uint32_t rate, uint8_t addr) if (bus) shutdown("Unsupported i2c bus"); i2c_init(); - return (struct i2c_config){ .addr=addr }; + return (struct i2c_config){ .addr=addr<<1 }; } static void |