diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-12-27 19:11:46 -0500 |
|---|---|---|
| committer | KevinOConnor <kevin@koconnor.net> | 2019-01-07 20:00:44 -0500 |
| commit | e26d1a356708b3702c91a86ff37f3c5c615941c9 (patch) | |
| tree | 89cbc00e3af6fe731c863da4a30b487b56a8badd /src/i2ccmds.c | |
| parent | f2f54290e84903679bdb9548924f933a6efe311d (diff) | |
| download | kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.tar.gz kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.tar.xz kutter-e26d1a356708b3702c91a86ff37f3c5c615941c9.zip | |
i2ccmds: Pass the i2c address as a 7-bit number (0-127)
The sam3 i2c code and the linux code use a 7-bit i2c address, while
the avr, lpc176x, and samd21 i2c code uses an 8-bit address with the
least significant bit always zero. A similar issue occurred in the
host code (sx1509.py and replicape.py use 7-bit addresses while
uc1701.py and mcp4451.py use 8-bit addresses).
Consistently use 7-bit addresses in all the code. This breaks
compatibility between host and mcu software, so make a change to the
config_i2c command to force users to synchronize software updates.
This also breaks common Smoothieboard configs, so update the mcp4451
code to validate the i2c_address.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'src/i2ccmds.c')
| -rw-r--r-- | src/i2ccmds.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/i2ccmds.c b/src/i2ccmds.c index d880b46f..01f7b36f 100644 --- a/src/i2ccmds.c +++ b/src/i2ccmds.c @@ -16,15 +16,13 @@ struct i2cdev_s { void command_config_i2c(uint32_t *args) { - uint8_t addr = args[3]; - if (addr & 1) - shutdown("Invalid I2C address"); + uint8_t addr = args[3] & 0x7f; struct i2cdev_s *i2c = oid_alloc(args[0], command_config_i2c , sizeof(*i2c)); i2c->i2c_config = i2c_setup(args[1], args[2], addr); } DECL_COMMAND(command_config_i2c, - "config_i2c oid=%c bus=%u rate=%u addr=%u"); + "config_i2c oid=%c bus=%u rate=%u address=%u"); void command_i2c_write(uint32_t *args) |