diff options
| author | Kevin O'Connor <kevin@koconnor.net> | 2018-05-15 17:04:30 -0400 |
|---|---|---|
| committer | Kevin O'Connor <kevin@koconnor.net> | 2018-05-15 17:09:11 -0400 |
| commit | 70068985a7dc8f9beb0091f2a53b2fbdf359523c (patch) | |
| tree | 8900af0be29376aa6e652f2219976fe12c5ffc96 /src/gpiocmds.c | |
| parent | 907cfb91053acdd6f751e7a03134295b29360a0f (diff) | |
| download | kutter-70068985a7dc8f9beb0091f2a53b2fbdf359523c.tar.gz kutter-70068985a7dc8f9beb0091f2a53b2fbdf359523c.tar.xz kutter-70068985a7dc8f9beb0091f2a53b2fbdf359523c.zip | |
stepper: Introduce and use gpio_out_toggle_noirq()
The gpio_out_toggle() function in the sam3x8e and stm32f1 code was
only valid if it was called with irqs disabled.
Commits 018c5daa and 9c52ad43 enabled the lcd code which called
gpio_out_toggle() with irqs enabled. This could cause corruption of
the gpio state.
Introduce a gpio_out_toggle_noirq() function that will only be invoked
with irqs disabled, and fix gpio_out_toggle() on sam3x8e and stm32f1
so that it safe to call even if irqs are enabled.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
Diffstat (limited to 'src/gpiocmds.c')
| -rw-r--r-- | src/gpiocmds.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gpiocmds.c b/src/gpiocmds.c index 54465459..cc221fc3 100644 --- a/src/gpiocmds.c +++ b/src/gpiocmds.c @@ -115,7 +115,7 @@ static uint_fast8_t soft_pwm_toggle_event(struct timer *timer) { struct soft_pwm_s *s = container_of(timer, struct soft_pwm_s, timer); - gpio_out_toggle(s->pin); + gpio_out_toggle_noirq(s->pin); s->flags ^= SPF_ON; uint32_t waketime = s->timer.waketime; if (s->flags & SPF_ON) |