diff options
| author | Janar Sööt <janar.soot@gmail.com> | 2020-08-14 20:42:33 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-14 13:42:33 -0400 |
| commit | b490848bc9055b0e439fca88c1438d60885ffabb (patch) | |
| tree | a56603c85cc88dcce6eaab4fc61d5d5cee5aa6de /klippy/extras/display | |
| parent | 7a615b4f69a2e9df7889b4801354ff04abff10c0 (diff) | |
| download | kutter-b490848bc9055b0e439fca88c1438d60885ffabb.tar.gz kutter-b490848bc9055b0e439fca88c1438d60885ffabb.tar.xz kutter-b490848bc9055b0e439fca88c1438d60885ffabb.zip | |
menu: fix for overwriting existing menu item (#3189)
In case of an overwriting existing menu item,
the new item was added additionally to the end of the items list.
Signed-off-by: Janar Sööt <janar.soot@gmail.com>
Diffstat (limited to 'klippy/extras/display')
| -rw-r--r-- | klippy/extras/display/menu.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/klippy/extras/display/menu.py b/klippy/extras/display/menu.py index 7dc05864..f565529b 100644 --- a/klippy/extras/display/menu.py +++ b/klippy/extras/display/menu.py @@ -934,14 +934,16 @@ class MenuManager: config, 'type', menu_items)(self, config) def add_menuitem(self, name, item): + existing_item = False if name in self.menuitems: + existing_item = True logging.info( "Declaration of '%s' hides " "previous menuitem declaration" % (name,)) self.menuitems[name] = item if isinstance(item, MenuElement): parent = item.get_ns('..') - if parent: + if parent and not existing_item: if item.index is not None: self.children.setdefault(parent, []).insert( item.index, item.get_ns()) |