Initial commit, cargo version 0.1

6 files changed, 577 insertions, 0 deletions

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..6936990
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+/target
+**/*.rs.bk
+Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
new file mode 100644
index 0000000..7871ca3
--- /dev/null
+++ b/Cargo.toml
@@ -0,0 +1,17 @@
+[package]
+name = "max31855"
+version = "0.1.0"
+authors = ["cs2dsb <cs2dsb@gmail.com>"]
+edition = "2018"
+description = "Driver for MAX31855 SPI thermocouple converter"
+categories = ["hardware-support"]
+keywords = ["embedded-hal-driver", "max31855", "no_std"]
+license = "MIT OR Apache-2.0"
+repository = "https://github.com/cs2dsb/max31855.rs"
+readme = "README.md"
+documentation = "https://docs.rs/max31855"
+homepage = "https://github.com/cs2dsb/max31855.rs"
+
+[dependencies]
+embedded-hal  = { version = "0.2.3" }
+bit_field     = "0.10.0"
\ No newline at end of file
diff --git a/LICENSE-APACHE b/LICENSE-APACHE
new file mode 100644
index 0000000..11069ed
--- /dev/null
+++ b/LICENSE-APACHE
@@ -0,0 +1,201 @@
+                              Apache License
+                        Version 2.0, January 2004
+                     http://www.apache.org/licenses/
+
+TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+1. Definitions.
+
+   "License" shall mean the terms and conditions for use, reproduction,
+   and distribution as defined by Sections 1 through 9 of this document.
+
+   "Licensor" shall mean the copyright owner or entity authorized by
+   the copyright owner that is granting the License.
+
+   "Legal Entity" shall mean the union of the acting entity and all
+   other entities that control, are controlled by, or are under common
+   control with that entity. For the purposes of this definition,
+   "control" means (i) the power, direct or indirect, to cause the
+   direction or management of such entity, whether by contract or
+   otherwise, or (ii) ownership of fifty percent (50%) or more of the
+   outstanding shares, or (iii) beneficial ownership of such entity.
+
+   "You" (or "Your") shall mean an individual or Legal Entity
+   exercising permissions granted by this License.
+
+   "Source" form shall mean the preferred form for making modifications,
+   including but not limited to software source code, documentation
+   source, and configuration files.
+
+   "Object" form shall mean any form resulting from mechanical
+   transformation or translation of a Source form, including but
+   not limited to compiled object code, generated documentation,
+   and conversions to other media types.
+
+   "Work" shall mean the work of authorship, whether in Source or
+   Object form, made available under the License, as indicated by a
+   copyright notice that is included in or attached to the work
+   (an example is provided in the Appendix below).
+
+   "Derivative Works" shall mean any work, whether in Source or Object
+   form, that is based on (or derived from) the Work and for which the
+   editorial revisions, annotations, elaborations, or other modifications
+   represent, as a whole, an original work of authorship. For the purposes
+   of this License, Derivative Works shall not include works that remain
+   separable from, or merely link (or bind by name) to the interfaces of,
+   the Work and Derivative Works thereof.
+
+   "Contribution" shall mean any work of authorship, including
+   the original version of the Work and any modifications or additions
+   to that Work or Derivative Works thereof, that is intentionally
+   submitted to Licensor for inclusion in the Work by the copyright owner
+   or by an individual or Legal Entity authorized to submit on behalf of
+   the copyright owner. For the purposes of this definition, "submitted"
+   means any form of electronic, verbal, or written communication sent
+   to the Licensor or its representatives, including but not limited to
+   communication on electronic mailing lists, source code control systems,
+   and issue tracking systems that are managed by, or on behalf of, the
+   Licensor for the purpose of discussing and improving the Work, but
+   excluding communication that is conspicuously marked or otherwise
+   designated in writing by the copyright owner as "Not a Contribution."
+
+   "Contributor" shall mean Licensor and any individual or Legal Entity
+   on behalf of whom a Contribution has been received by Licensor and
+   subsequently incorporated within the Work.
+
+2. Grant of Copyright License. Subject to the terms and conditions of
+   this License, each Contributor hereby grants to You a perpetual,
+   worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+   copyright license to reproduce, prepare Derivative Works of,
+   publicly display, publicly perform, sublicense, and distribute the
+   Work and such Derivative Works in Source or Object form.
+
+3. Grant of Patent License. Subject to the terms and conditions of
+   this License, each Contributor hereby grants to You a perpetual,
+   worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+   (except as stated in this section) patent license to make, have made,
+   use, offer to sell, sell, import, and otherwise transfer the Work,
+   where such license applies only to those patent claims licensable
+   by such Contributor that are necessarily infringed by their
+   Contribution(s) alone or by combination of their Contribution(s)
+   with the Work to which such Contribution(s) was submitted. If You
+   institute patent litigation against any entity (including a
+   cross-claim or counterclaim in a lawsuit) alleging that the Work
+   or a Contribution incorporated within the Work constitutes direct
+   or contributory patent infringement, then any patent licenses
+   granted to You under this License for that Work shall terminate
+   as of the date such litigation is filed.
+
+4. Redistribution. You may reproduce and distribute copies of the
+   Work or Derivative Works thereof in any medium, with or without
+   modifications, and in Source or Object form, provided that You
+   meet the following conditions:
+
+   (a) You must give any other recipients of the Work or
+       Derivative Works a copy of this License; and
+
+   (b) You must cause any modified files to carry prominent notices
+       stating that You changed the files; and
+
+   (c) You must retain, in the Source form of any Derivative Works
+       that You distribute, all copyright, patent, trademark, and
+       attribution notices from the Source form of the Work,
+       excluding those notices that do not pertain to any part of
+       the Derivative Works; and
+
+   (d) If the Work includes a "NOTICE" text file as part of its
+       distribution, then any Derivative Works that You distribute must
+       include a readable copy of the attribution notices contained
+       within such NOTICE file, excluding those notices that do not
+       pertain to any part of the Derivative Works, in at least one
+       of the following places: within a NOTICE text file distributed
+       as part of the Derivative Works; within the Source form or
+       documentation, if provided along with the Derivative Works; or,
+       within a display generated by the Derivative Works, if and
+       wherever such third-party notices normally appear. The contents
+       of the NOTICE file are for informational purposes only and
+       do not modify the License. You may add Your own attribution
+       notices within Derivative Works that You distribute, alongside
+       or as an addendum to the NOTICE text from the Work, provided
+       that such additional attribution notices cannot be construed
+       as modifying the License.
+
+   You may add Your own copyright statement to Your modifications and
+   may provide additional or different license terms and conditions
+   for use, reproduction, or distribution of Your modifications, or
+   for any such Derivative Works as a whole, provided Your use,
+   reproduction, and distribution of the Work otherwise complies with
+   the conditions stated in this License.
+
+5. Submission of Contributions. Unless You explicitly state otherwise,
+   any Contribution intentionally submitted for inclusion in the Work
+   by You to the Licensor shall be under the terms and conditions of
+   this License, without any additional terms or conditions.
+   Notwithstanding the above, nothing herein shall supersede or modify
+   the terms of any separate license agreement you may have executed
+   with Licensor regarding such Contributions.
+
+6. Trademarks. This License does not grant permission to use the trade
+   names, trademarks, service marks, or product names of the Licensor,
+   except as required for reasonable and customary use in describing the
+   origin of the Work and reproducing the content of the NOTICE file.
+
+7. Disclaimer of Warranty. Unless required by applicable law or
+   agreed to in writing, Licensor provides the Work (and each
+   Contributor provides its Contributions) on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+   implied, including, without limitation, any warranties or conditions
+   of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+   PARTICULAR PURPOSE. You are solely responsible for determining the
+   appropriateness of using or redistributing the Work and assume any
+   risks associated with Your exercise of permissions under this License.
+
+8. Limitation of Liability. In no event and under no legal theory,
+   whether in tort (including negligence), contract, or otherwise,
+   unless required by applicable law (such as deliberate and grossly
+   negligent acts) or agreed to in writing, shall any Contributor be
+   liable to You for damages, including any direct, indirect, special,
+   incidental, or consequential damages of any character arising as a
+   result of this License or out of the use or inability to use the
+   Work (including but not limited to damages for loss of goodwill,
+   work stoppage, computer failure or malfunction, or any and all
+   other commercial damages or losses), even if such Contributor
+   has been advised of the possibility of such damages.
+
+9. Accepting Warranty or Additional Liability. While redistributing
+   the Work or Derivative Works thereof, You may choose to offer,
+   and charge a fee for, acceptance of support, warranty, indemnity,
+   or other liability obligations and/or rights consistent with this
+   License. However, in accepting such obligations, You may act only
+   on Your own behalf and on Your sole responsibility, not on behalf
+   of any other Contributor, and only if You agree to indemnify,
+   defend, and hold each Contributor harmless for any liability
+   incurred by, or claims asserted against, such Contributor by reason
+   of your accepting any such warranty or additional liability.
+
+END OF TERMS AND CONDITIONS
+
+APPENDIX: How to apply the Apache License to your work.
+
+   To apply the Apache License to your work, attach the following
+   boilerplate notice, with the fields enclosed by brackets "[]"
+   replaced with your own identifying information. (Don't include
+   the brackets!)  The text should be enclosed in the appropriate
+   comment syntax for the file format. We also recommend that a
+   file or class name and description of purpose be included on the
+   same "printed page" as the copyright notice for easier
+   identification within third-party archives.
+
+Copyright [yyyy] [name of copyright owner]
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
diff --git a/LICENSE-MIT b/LICENSE-MIT
new file mode 100644
index 0000000..77e5386
--- /dev/null
+++ b/LICENSE-MIT
@@ -0,0 +1,25 @@
+Copyright (c) 2019 cs2dsb
+
+Permission is hereby granted, free of charge, to any
+person obtaining a copy of this software and associated
+documentation files (the "Software"), to deal in the
+Software without restriction, including without
+limitation the rights to use, copy, modify, merge,
+publish, distribute, sublicense, and/or sell copies of
+the Software, and to permit persons to whom the Software
+is furnished to do so, subject to the following
+conditions:
+
+The above copyright notice and this permission notice
+shall be included in all copies or substantial portions
+of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF
+ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED
+TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A
+PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
+SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR
+IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..78a4ae6
--- /dev/null
+++ b/README.md
@@ -0,0 +1,49 @@
+# max31855
+
+Driver for [MAX31855 thermocouple converter](https://www.maximintegrated.com/en/products/sensors/MAX31855.html) using traits from `embedded-hal`.
+
+[![Crate](https://img.shields.io/crates/v/max31855.svg)](https://crates.io/crates/max31855)
+[![Documentation](https://docs.rs/max31855/badge.svg)](https://docs.rs/max31855)
+
+## Features
+* Read thermocouple temperature
+* Read internal reference junction temperature
+* Read fault data (missing thermocouple, short to ground or short to vcc)
+* Supports 16-bit (thermocouple + fault only) or 32-bit (thermocouple, internal and full fault details)
+* Supports Celsius, Fahrenheit or Kelvin units
+* Supports returning raw (ADC count) readings
+
+## Example:
+```
+    let freq: Hertz = 4.mhz().into();
+    let mode = Mode {
+        polarity: Polarity::IdleLow,
+        phase: Phase::CaptureOnFirstTransition
+    };
+
+    let mut spi = Spi::spi2(
+        device.SPI2,
+        (sck_pin, miso_pin, mosi_pin)
+        mode,
+        freq,
+        clocks,
+        &mut rcc.apb1
+    );
+
+    // Full 32-bit read, result contains both thermocouple and internal temperatures
+    match spi.read_all(&mut cs_pin, Unit::Celsius) {
+        Ok(v) => info!("Ok: {:?}", v),
+        Err(e) => info!("Err: {:?}", e),
+    }
+
+    // Just thermocouple 16-bit read
+    match spi.read_thermocouple(&mut cs_pin, Unit::Celsius) {
+        Ok(v) => info!("Ok: {:?}", v),
+        Err(e) => info!("Err: {:?}", e),
+    }
+```
+
+Free and open source software distributed under the terms of both the [MIT License][lm] and the [Apache License 2.0][la].
+
+[lm]: LICENSE-MIT
+[la]: LICENSE-APACHE
\ No newline at end of file
diff --git a/src/lib.rs b/src/lib.rs
new file mode 100644
index 0000000..d88d273
--- /dev/null
+++ b/src/lib.rs
@@ -0,0 +1,282 @@
+//! # max31855
+//! 
+//! Driver for [MAX31855 thermocouple converter](https://www.maximintegrated.com/en/products/sensors/MAX31855.html) using traits from `embedded-hal`.
+//!
+//! ## Features
+//! * Read thermocouple temperature
+//! * Read internal reference junction temperature
+//! * Read fault data (missing thermocouple, short to ground or short to vcc)
+//! * Supports 16-bit (thermocouple + fault only) or 32-bit (thermocouple, internal and full fault details)
+//! * Supports Celsius, Fahrenheit or Kelvin units
+//! * Supports returning raw (ADC count) readings
+//!
+//! ## Example:
+//! ```
+//!     let freq: Hertz = 4.mhz().into();
+//!     let mode = Mode {
+//!         polarity: Polarity::IdleLow,
+//!         phase: Phase::CaptureOnFirstTransition
+//!     };
+//! 
+//!     let mut spi = Spi::spi2(
+//!         device.SPI2,
+//!         (sck_pin, miso_pin, mosi_pin)
+//!         mode,
+//!         freq,
+//!         clocks,
+//!         &mut rcc.apb1
+//!     );
+//! 
+//!     // Full 32-bit read, result contains both thermocouple and internal temperatures
+//!     match spi.read_all(&mut cs_pin, Unit::Celsius) {
+//!         Ok(v) => info!("Ok: {:?}", v),
+//!         Err(e) => info!("Err: {:?}", e),
+//!     }
+//! 
+//!     // Just thermocouple 16-bit read
+//!     match spi.read_thermocouple(&mut cs_pin, Unit::Celsius) {
+//!         Ok(v) => info!("Ok: {:?}", v),
+//!         Err(e) => info!("Err: {:?}", e),
+//!     }
+//! ```
+
+#![no_std]
+#![deny(warnings, missing_docs)]
+
+use embedded_hal::{
+    blocking::spi::Transfer,
+    digital::v2::OutputPin,
+};
+use bit_field::BitField;
+use core::ops::RangeInclusive;
+
+/// The bits that represent the thermocouple value when reading the first u16 from the sensor
+const THERMOCOUPLE_BITS: RangeInclusive<usize> = 2..=15;
+/// The bit that indicates some kind of fault when reading the first u16 from the sensor
+const FAULT_BIT: usize = 0;
+/// The bits that represent the internal value when reading the second u16 from the sensor
+const INTERNAL_BITS: RangeInclusive<usize> = 4..=15;
+/// The bit that indicates a short-to-vcc fault when reading the second u16 from the sensor
+const FAULT_VCC_SHORT_BIT: usize = 2;
+/// The bit that indicates a short-to-gnd fault when reading the second u16 from the sensor
+const FAULT_GROUND_SHORT_BIT: usize = 1;
+/// The bit that indicates a missing thermocouple fault when reading the second u16 from the sensor
+const FAULT_NO_THERMOCOUPLE_BIT: usize = 0;
+
+/// Possible errors returned by this crate
+#[derive(Debug)]
+pub enum Error<SpiE, CsE> {
+    /// An error returned by a call to Transfer::transfer
+    SpiError(SpiE),
+    /// An error returned by a call to OutputPin::{set_high, set_low}
+    ChipSelectError(CsE),
+    /// The fault bit (16) was set in the response from the MAX31855
+    Fault,
+    /// The SCV fault bit (2) was set in the response from the MAX31855
+    VccShortFault,
+    /// The SCG fault bit (1) was set in the response from the MAX31855
+    GroundShortFault,
+    /// The OC fault bit (0) was set in the response from the MAX31855
+    MissingThermocoupleFault,
+}
+
+/// The temperature unit to use
+#[derive(Clone, Copy, Debug)]
+pub enum Unit {
+    /// Degrees Celsius
+    Celsius,
+    /// Degrees Fahrenheit
+    Fahrenheit,
+    /// Degrees Kelvin
+    Kelvin,
+}
+
+impl Unit {
+    /// Converts degrees celsius into this unit
+    pub fn convert(&self, celsius: f32) -> f32 {
+        match self {
+            Unit::Celsius => celsius,
+            Unit::Fahrenheit => celsius * 1.8 + 32.,
+            Unit::Kelvin => celsius + 273.15,
+        }
+    }
+}
+
+/// Possible MAX31855 readings
+pub enum Reading {
+    /// The attached thermocouple
+    Thermocouple,
+    /// The internal reference junction
+    Internal,
+}
+
+impl Reading {
+    /// Convert the raw ADC count into degrees celsius
+    pub fn convert(self, count: i16) -> f32 {
+        let count = count as f32;
+        match self {
+            Reading::Thermocouple => count * 0.25,
+            Reading::Internal => count * 0.0625,
+        }
+    }
+}
+
+enum CsState {
+    High,
+    Low,
+}
+use CsState::*;
+
+fn set_cs<CS, SpiE, CsE>(cs: &mut CS, state: CsState) -> Result<(), Error<SpiE, CsE>>
+where
+    CS: OutputPin<Error = CsE>, 
+{
+    let result = match state {
+        CsState::High => cs.set_high(),
+        CsState::Low => cs.set_low(),
+    };
+
+    result.map_err(|e| Error::ChipSelectError(e))
+}
+
+fn transfer<CS, SPI, SpiE, CsE>(spi: &mut SPI, chip_select: &mut CS, buffer: &mut [u8]) -> Result<(), Error<SpiE, CsE>>
+where
+    CS: OutputPin<Error = CsE>, 
+    SPI: Transfer<u8, Error = SpiE>,
+{
+    set_cs(chip_select, Low)?;
+
+    spi.transfer(buffer).map_err(|e| Error::SpiError(e))?;
+
+    set_cs(chip_select, High)
+}
+
+fn bits_to_i16(bits: u16, len: usize, divisor: i16, shift: usize) -> i16 {
+    let negative = bits.get_bit(len - 1);
+    if negative {
+        (bits << shift) as i16 / divisor
+    } else {
+        bits as i16
+    }
+}
+
+/// Represents the data contained in a full 32-bit read from the MAX31855 as raw ADC counts
+#[derive(Debug)]
+pub struct FullResultRaw {
+    /// The temperature of the thermocouple as raw ADC counts
+    pub thermocouple: i16,
+    /// The temperature of the MAX31855 reference junction as raw ADC counts
+    pub internal: i16,
+}
+
+impl FullResultRaw {
+    /// Convert the raw ADC counts into degrees in the provided Unit
+    pub fn convert(self, unit: Unit) -> FullResult {        
+        let thermocouple = unit.convert(Reading::Thermocouple.convert(self.thermocouple));        
+        let internal = unit.convert(Reading::Internal.convert(self.internal));
+
+        FullResult {
+            thermocouple,
+            internal,
+            unit,
+        }
+    }
+}
+
+/// Represents the data contained in a full 32-bit read from the MAX31855 as degrees in the included Unit
+#[derive(Debug)]
+pub struct FullResult {
+    /// The temperature of the thermocouple
+    pub thermocouple: f32,
+    /// The temperature of the MAX31855 reference junction
+    pub internal: f32,
+    /// The unit that the temperatures are in
+    pub unit: Unit,
+}
+
+/// Trait enabling using the MAX31855
+pub trait Max31855<SpiE, CsE, CS> {
+    /// Reads the thermocouple temperature and leave it as a raw ADC count. Checks if there is a fault but doesn't detect what kind of fault it is
+    fn read_thermocouple_raw(&mut self, chip_select: &mut CS) -> Result<i16, Error<SpiE, CsE>>;
+    /// Reads the thermocouple temperature and converts it into degrees in the provided unit. Checks if there is a fault but doesn't detect what kind of fault it is
+    fn read_thermocouple(&mut self, chip_select: &mut CS, unit: Unit) -> Result<f32, Error<SpiE, CsE>>;
+    /// Reads both the thermocouple and the internal temperatures, leaving them as raw ADC counts and resolves faults to one of vcc short, ground short or missing thermocouple
+    fn read_all_raw(&mut self, chip_select: &mut CS) -> Result<FullResultRaw, Error<SpiE, CsE>>;
+    /// Reads both the thermocouple and the internal temperatures, converts them into degrees in the provided unit and resolves faults to one of vcc short, ground short or missing thermocouple
+    fn read_all(&mut self, chip_select: &mut CS, unit: Unit) -> Result<FullResult, Error<SpiE, CsE>>;
+}
+
+impl<CS, SPI, SpiE, CsE> Max31855<SpiE, CsE, CS> for SPI
+where
+    CS: OutputPin<Error = CsE>, 
+    SPI: Transfer<u8, Error = SpiE>,
+{
+    /// Reads the thermocouple temperature and leave it as a raw ADC count. Checks if there is a fault but doesn't detect what kind of fault it is
+    fn read_thermocouple_raw(&mut self, chip_select: &mut CS) -> Result<i16, Error<SpiE, CsE>> {
+        let mut buffer = [0; 2];
+        transfer(self, chip_select, &mut buffer)?;
+
+        if buffer[1].get_bit(FAULT_BIT) {
+            Err(Error::Fault)?
+        }
+
+        let raw = (buffer[0] as u16) << 8 |
+                  (buffer[1] as u16) << 0;
+
+        let thermocouple = bits_to_i16(raw.get_bits(THERMOCOUPLE_BITS), 14, 4, 2);
+        
+        Ok(thermocouple)
+    }
+
+    /// Reads the thermocouple temperature and converts it into degrees in the provided unit. Checks if there is a fault but doesn't detect what kind of fault it is
+    fn read_thermocouple(&mut self, chip_select: &mut CS, unit: Unit) -> Result<f32, Error<SpiE, CsE>> {
+        self
+            .read_thermocouple_raw(chip_select)
+            .map(|r| unit.convert(Reading::Thermocouple.convert(r)))
+    }
+
+    /// Reads both the thermocouple and the internal temperatures, leaving them as raw ADC counts and resolves faults to one of vcc short, ground short or missing thermocouple
+    fn read_all_raw(&mut self, chip_select: &mut CS) -> Result<FullResultRaw, Error<SpiE, CsE>> {
+        let mut buffer = [0; 4];
+        transfer(self, chip_select, &mut buffer)?;
+
+        let fault = buffer[1].get_bit(0);
+
+        if fault {
+            let raw = (buffer[2] as u16) << 8 |
+                      (buffer[3] as u16) << 0;
+
+            if raw.get_bit(FAULT_NO_THERMOCOUPLE_BIT) {
+                Err(Error::MissingThermocoupleFault)?
+            } else if raw.get_bit(FAULT_GROUND_SHORT_BIT) {
+                Err(Error::GroundShortFault)?
+            } else if raw.get_bit(FAULT_VCC_SHORT_BIT) {
+                Err(Error::VccShortFault)?
+            } else {
+                // This should impossible, one of the other fields should be set as well
+                // but handled here just-in-case
+                Err(Error::Fault)?
+            }
+        }
+
+        let first_u16 = (buffer[0] as u16) << 8 |
+                        (buffer[1] as u16) << 0;
+        let second_u16 = (buffer[2] as u16) << 8 |
+                         (buffer[3] as u16) << 0;
+        
+        let thermocouple = bits_to_i16(first_u16.get_bits(THERMOCOUPLE_BITS), 14, 4, 2);
+        let internal = bits_to_i16(second_u16.get_bits(INTERNAL_BITS), 12, 16, 4);
+
+        Ok(FullResultRaw {
+            thermocouple,
+            internal,
+        })
+    }
+
+    /// Reads both the thermocouple and the internal temperatures, converts them into degrees in the provided unit and resolves faults to one of vcc short, ground short or missing thermocouple
+    fn read_all(&mut self, chip_select: &mut CS, unit: Unit) -> Result<FullResult, Error<SpiE, CsE>> {
+        self
+            .read_all_raw(chip_select)
+            .map(|r| r.convert(unit))
+    }
+}
\ No newline at end of file