From f54b7b9376ac86d5073e1df875c199184dfafb23 Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Wed, 11 Jun 2025 17:59:02 -0400 Subject: sos_filter: Fix validate_section_index() check A section_idx equal to max_sections is also invalid. Signed-off-by: Kevin O'Connor --- src/sos_filter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/sos_filter.c b/src/sos_filter.c index 3ec5d617..04eb366e 100644 --- a/src/sos_filter.c +++ b/src/sos_filter.c @@ -108,7 +108,7 @@ sos_filter_oid_lookup(uint8_t oid) static void validate_section_index(struct sos_filter *sf, uint8_t section_idx) { - if (section_idx > sf->max_sections) + if (section_idx >= sf->max_sections) shutdown("Filter section index larger than max_sections"); } @@ -154,7 +154,8 @@ command_sos_filter_activate(uint32_t *args) { struct sos_filter *sf = sos_filter_oid_lookup(args[0]); uint8_t n_sections = args[1]; - validate_section_index(sf, n_sections); + if (n_sections > sf->max_sections) + shutdown("Filter section index larger than max_sections"); sf->n_sections = n_sections; const uint8_t coeff_int_bits = args[2]; sf->coeff_frac_bits = (31 - coeff_int_bits); -- cgit v1.2.3-70-g09d2