From 273a98d39a88a372c8a2c816622e7df1f777e77d Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Thu, 26 Jul 2018 09:44:45 -0400 Subject: pins: Explicitly pass can_invert and can_pullup to lookup_pin() Don't pass pin_type to lookup_pin() - instead, if a pin can be inverted or can have a pullup, then the caller must explicitly specify that when calling lookup_pin(). This simplifies the code for the cases where it is not valid to invert or pullup. Explicitly pass the pin_type to setup_pin() and have ppins.setup_pin() apply default pullup and invert flags. Signed-off-by: Kevin O'Connor --- klippy/extras/ad5206.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'klippy/extras/ad5206.py') diff --git a/klippy/extras/ad5206.py b/klippy/extras/ad5206.py index a4764464..ec4db4e5 100644 --- a/klippy/extras/ad5206.py +++ b/klippy/extras/ad5206.py @@ -8,9 +8,7 @@ class ad5206: def __init__(self, config): ppins = config.get_printer().lookup_object('pins') enable_pin = config.get('enable_pin') - enable_pin_params = ppins.lookup_pin('digital_out', enable_pin) - if enable_pin_params['invert']: - raise ppins.error("ad5206 can not invert pin") + enable_pin_params = ppins.lookup_pin(enable_pin) mcu = enable_pin_params['chip'] pin = enable_pin_params['pin'] scale = config.getfloat('scale', 1., above=0.) -- cgit v1.2.3-70-g09d2