diff options
| -rw-r--r-- | docs/Todo.md | 3 | ||||
| -rw-r--r-- | klippy/queuelogger.py | 8 |
2 files changed, 4 insertions, 7 deletions
diff --git a/docs/Todo.md b/docs/Todo.md index 672a4c2c..b0bc69a4 100644 --- a/docs/Todo.md +++ b/docs/Todo.md @@ -26,9 +26,6 @@ Host user interaction * Improve logging: - * Automatically roll Klippy log files. The default log file should - have the current date in the log file name. - * Possibly collate and report the statistics messages in the log in a more friendly way. diff --git a/klippy/queuelogger.py b/klippy/queuelogger.py index 8494c6a8..38a3d423 100644 --- a/klippy/queuelogger.py +++ b/klippy/queuelogger.py @@ -1,9 +1,9 @@ # Code to implement asynchronous logging from a background thread # -# Copyright (C) 2016 Kevin O'Connor <kevin@koconnor.net> +# Copyright (C) 2016,2017 Kevin O'Connor <kevin@koconnor.net> # # This file may be distributed under the terms of the GNU GPLv3 license. -import logging, threading, Queue +import logging, logging.handlers, threading, Queue # Class to forward all messages through a queue to a background thread class QueueHandler(logging.Handler): @@ -38,8 +38,8 @@ class QueueListener(object): self.thread.join() def setup_bg_logging(filename, debuglevel): - logoutput = open(filename, 'wb') - handler = logging.StreamHandler(logoutput) + handler = logging.handlers.TimedRotatingFileHandler( + filename, when='midnight', backupCount=5) ql = QueueListener(handler) qh = QueueHandler(ql.queue) root = logging.getLogger() |